Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(tests): update cheerio snapshots #31298

Merged
merged 1 commit into from May 7, 2021
Merged

fix(tests): update cheerio snapshots #31298

merged 1 commit into from May 7, 2021

Conversation

hoobdeebla
Copy link
Contributor

@hoobdeebla hoobdeebla commented May 6, 2021 •
edited

cheerio v1.0.0-rc.6 introduced some slight parsing differences that have no impact on production code but cause tests to fail. Today's merger of #31163 did not account for the snapshot updates and only updated the package.json of gatsby-remark-copy-linked-files, but it deduped cheerio for the monorepo to v1.0.0-rc.9 and thus broke testing. This PR updates cheerio in all packages to v1.0.0-rc.9 and updates the failing snapshots.

@gatsbot gatsbot bot added the status: triage needed Issue or pull request that need to be triaged and assigned to a reviewer label May 6, 2021
@hoobdeebla
Copy link
Contributor Author

looks like the Windows tests didn't run because CircleCI thought node wasn't a command 😄

LekoArts
LekoArts approved these changes May 7, 2021
View reviewed changes
Copy link
Contributor

@LekoArts LekoArts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@LekoArts LekoArts added type: maintenance An issue or pull request describing a change that isn't a bug, feature or documentation change and removed status: triage needed Issue or pull request that need to be triaged and assigned to a reviewer labels May 7, 2021
@LekoArts LekoArts merged commit e06599d into gatsbyjs:master May 7, 2021
@hoobdeebla hoobdeebla deleted the updates/cheerio branch May 7, 2021 07:57
@vladar vladar added this to To cherry-pick in V3 Release Hotfixes via automation May 19, 2021
vladar pushed a commit that referenced this pull request May 19, 2021
@hoobdeebla @vladar
fix(tests): update cheerio snapshots (#31298)
d788795 
(cherry picked from commit e06599d)

# Conflicts:
#	packages/gatsby-plugin-offline/package.json
#	packages/gatsby-remark-images/package.json
#	packages/gatsby-remark-prismjs/package.json
@vladar vladar mentioned this pull request May 19, 2021
Merged
@vladar vladar moved this from To cherry-pick to Backport PR opened in V3 Release Hotfixes May 19, 2021
vladar added a commit that referenced this pull request May 19, 2021
@vladar @hoobdeebla
fix(tests): update cheerio snapshots (#31298) (#31483)
67a4fce 
(cherry picked from commit e06599d)

# Conflicts:
#	packages/gatsby-plugin-offline/package.json
#	packages/gatsby-remark-images/package.json
#	packages/gatsby-remark-prismjs/package.json

Co-authored-by: Adam Schay <adamschay@gmail.com>
@vladar vladar moved this from Backport PR opened to Backported in V3 Release Hotfixes May 19, 2021
@vladar vladar moved this from Backported to Published in V3 Release Hotfixes May 19, 2021
axe312ger pushed a commit that referenced this pull request May 20, 2021
@hoobdeebla @axe312ger
fix(tests): update cheerio snapshots (#31298)
37327e0
@LekoArts LekoArts removed this from Published in V3 Release Hotfixes May 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LekoArts LekoArts LekoArts approved these changes

Assignees
No one assigned
Labels
type: maintenance An issue or pull request describing a change that isn't a bug, feature or documentation change
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@hoobdeebla @LekoArts