fix(gatsby-source-wordpress): schema customization errors #30358
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…revent gql errors with interfaces
…s are gatsby node types
gatsbot
bot
added
the
status: triage needed
TylerBarnes
added
topic: source-wordpress
TylerBarnes
commented
Mar 23, 2021
...-source-wordpress/src/steps/create-schema-customization/transform-fields/default-resolver.js
Show resolved
Hide resolved
sslotsky
reviewed
Mar 23, 2021
packages/gatsby-source-wordpress/src/steps/create-schema-customization/build-types.js
Outdated
Show resolved
Hide resolved
sslotsky
reviewed
Mar 23, 2021
packages/gatsby-source-wordpress/src/steps/create-schema-customization/index.js
Outdated
Show resolved
Hide resolved
sslotsky
approved these changes
Mar 24, 2021
…tomization-errors
|
Seems like the failing tests are unrelated to this PR |
|
Should this be a V2 hotfix? Or V3? V3 project is |
|
@vladar I've heard from some users that they haven't been able to move on from v2 yet because they've run into a lot of troubles. I did ask them to open issues so we can fix them but I know they're still on v2 for now. Do we have a support plan for v2? EDIT: I checked that the v3 specific change with prefixing the __typename field works on Gatsby v2 if that's why you're asking. The other schema customization issues were present in v2 as well. |
|
Yeah I was confused by the first item in the list: So I assumed it was a fix for v3. Thanks for clarifying this 👍
Are there any related open issues about it? |
pieh
pushed a commit
that referenced
this pull request
Apr 2, 2021
* use new reporter.panic signature with error code for schema customization * add the prefixed typename as a node property when creating nodes to prevent gql errors with interfaces * fix union types that have a field called "type" * prevent excluded types from throwing errors in connection fields * test node interface resolution * test that interfaces that are mixed node and non-node resolve * prefix the __typename field in the default resolver for Gatsby v3 * an interface type is only a gatsby node type if all implementing types are gatsby node types * exclude Commenter.databaseId in int tests to get around WPGQL bug * only return null if there's no gatsby node AND no resolved field data (cherry picked from commit 5c9b744)
pieh
pushed a commit
that referenced
this pull request
Apr 2, 2021
* use new reporter.panic signature with error code for schema customization * add the prefixed typename as a node property when creating nodes to prevent gql errors with interfaces * fix union types that have a field called "type" * prevent excluded types from throwing errors in connection fields * test node interface resolution * test that interfaces that are mixed node and non-node resolve * prefix the __typename field in the default resolver for Gatsby v3 * an interface type is only a gatsby node type if all implementing types are gatsby node types * exclude Commenter.databaseId in int tests to get around WPGQL bug * only return null if there's no gatsby node AND no resolved field data (cherry picked from commit 5c9b744)
pieh
pushed a commit
that referenced
this pull request
Apr 7, 2021
…30650) * use new reporter.panic signature with error code for schema customization * add the prefixed typename as a node property when creating nodes to prevent gql errors with interfaces * fix union types that have a field called "type" * prevent excluded types from throwing errors in connection fields * test node interface resolution * test that interfaces that are mixed node and non-node resolve * prefix the __typename field in the default resolver for Gatsby v3 * an interface type is only a gatsby node type if all implementing types are gatsby node types * exclude Commenter.databaseId in int tests to get around WPGQL bug * only return null if there's no gatsby node AND no resolved field data (cherry picked from commit 5c9b744) Co-authored-by: Tyler Barnes <tyler@gatsbyjs.com>
This was referenced Jul 16, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes:
Abstract type \"WpTermNode\" was resolve to a type \"Category\" that does not exist inside schema.since the typename is actually WpCategory.