Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(gatsby): freeze the schema only after rebuilding with SitePage #30132

Merged
merged 1 commit into from
Mar 9, 2021
Merged

fix(gatsby): freeze the schema only after rebuilding with SitePage #30132

merged 1 commit into from
Mar 9, 2021

Conversation

vladar
Copy link
Contributor

@vladar vladar commented Mar 9, 2021

Description

The PR #29822 introduced an issue: types derived from SitePage are not updated correctly because the Query type gets frozen too early and doesn't receive needed updates when rebuilding the schema with SitePage.

This PR moves type freezing to a safer stage - after the schema is updated with SitePage and all of it's derived types.

Related Issues

Fixes #30107

@gatsbot gatsbot bot added the status: triage needed Issue or pull request that need to be triaged and assigned to a reviewer label Mar 9, 2021
@vladar vladar added topic: GraphQL Related to Gatsby's GraphQL layer and removed status: triage needed Issue or pull request that need to be triaged and assigned to a reviewer labels Mar 9, 2021
@vladar vladar mentioned this pull request Mar 9, 2021
Closed
@vladar vladar changed the title fix(gatsby): freeze the schma only after rebuilding with SitePage fix(gatsby): freeze the schema only after rebuilding with SitePage Mar 9, 2021
@vladar vladar added this to To cherry-pick in V3 Release Hotfixes via automation Mar 9, 2021
@vladar vladar merged commit 4fc4248 into master Mar 9, 2021
@vladar vladar deleted the vladar/gh-30107 branch March 9, 2021 13:03
@ahmadkhalaf1
Copy link

Hi ,
can you please tell me if is this going to be published in a new Gatsby version ? 3.0.4? and when ?
Thanks

vladar added a commit that referenced this pull request Mar 9, 2021
@vladar
fix(gatsby): freeze the schema only after rebuilding with SitePage (#…
bc715ea 
…30132)

(cherry picked from commit 4fc4248)
@gatsbybot gatsbybot mentioned this pull request Mar 9, 2021
Merged
@vladar vladar moved this from To cherry-pick to Backport PR opened in V3 Release Hotfixes Mar 9, 2021
vladar added a commit that referenced this pull request Mar 9, 2021
@vladar
fix(gatsby): freeze the schema only after rebuilding with SitePage (#…
31e754f 
…30132) (#30137)

(cherry picked from commit 4fc4248)

Co-authored-by: Vladimir Razuvaev <vladimir.razuvaev@gmail.com>
@vladar
Copy link
Contributor Author

vladar commented Mar 9, 2021

Published in gatsby@3.0.4

@vladar vladar moved this from Backport PR opened to Backported in V3 Release Hotfixes Mar 9, 2021
This was referenced Mar 9, 2021
Closed
Closed
Closed
@vladar vladar moved this from Backported to Archived in V3 Release Hotfixes Mar 10, 2021
This was referenced Mar 11, 2021
Closed
Merged
Closed
Merged
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pieh pieh pieh approved these changes

Assignees
No one assigned
Labels
topic: GraphQL Related to Gatsby's GraphQL layer
Projects
No open projects
V3 Release Hotfixes
Published
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Gatsby 3: graphql query during createPages breaks allSitePage:filter:
3 participants
@vladar @ahmadkhalaf1 @pieh