fix(gatsby-plugin-sass): Change modules option around
#29986
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gatsbot
bot
added
the
status: triage needed
LekoArts
changed the title
modules optionmodules option around
LekoArts
removed
the
status: triage needed
wardpeet
approved these changes
Mar 4, 2021
Titou325
approved these changes
Mar 4, 2021
vladar
pushed a commit
that referenced
this pull request
Mar 4, 2021
(cherry picked from commit bba21cd)
vladar
pushed a commit
that referenced
this pull request
Mar 4, 2021
) (cherry picked from commit bba21cd) Co-authored-by: Lennart <lekoarts@gmail.com>
|
Published in |
wardpeet
added a commit
that referenced
this pull request
Mar 5, 2021
…)" This reverts commit bba21cd.
This was referenced Mar 8, 2021
This was referenced Mar 17, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Luckily for us, with v4 the
modulesoption is set totrueby default. https://github.com/webpack-contrib/css-loader/blob/master/CHANGELOG.md#400-2020-07-25So we can explicitly set it to
falsefor the non-module rule (because it increases performance: https://github.com/webpack-contrib/css-loader#modules) and for the module rule we don't have to set it totrueanymore.Related Issues
Fixes #29955
[ch26275]