Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(gatsby): fix routing for paths with characters like @ etc #29935

Merged
merged 3 commits into from
Mar 3, 2021
Merged

fix(gatsby): fix routing for paths with characters like @ etc #29935

merged 3 commits into from
Mar 3, 2021

Conversation

pieh
Copy link
Contributor

@pieh pieh commented Mar 2, 2021 •
edited

Description

Just tests for the start

@gatsbot gatsbot bot added the status: triage needed Issue or pull request that need to be triaged and assigned to a reviewer label Mar 2, 2021
@pieh pieh added topic: reach/router and navigation and removed status: triage needed Issue or pull request that need to be triaged and assigned to a reviewer labels Mar 2, 2021
@pieh pieh marked this pull request as ready for review March 2, 2021 21:34
@pieh pieh force-pushed the fix-encodable-path-routing branch from 70cf6bb to a9f0814 Compare March 3, 2021 09:08
@pieh pieh marked this pull request as draft March 3, 2021 09:15
@pieh pieh mentioned this pull request Mar 3, 2021
Merged
@pieh pieh force-pushed the fix-encodable-path-routing branch from a9f0814 to 49ec2de Compare March 3, 2021 10:53
@pieh pieh marked this pull request as ready for review March 3, 2021 11:39
@pieh pieh merged commit 157ae16 into master Mar 3, 2021
@pieh pieh deleted the fix-encodable-path-routing branch March 3, 2021 11:59
@pieh pieh added this to To cherry-pick in V3 Release Hotfixes via automation Mar 3, 2021
@gatsbybot gatsbybot mentioned this pull request Mar 3, 2021
Merged
vladar pushed a commit that referenced this pull request Mar 3, 2021
@pieh @vladar
fix(gatsby): fix routing for paths with characters like @ etc (#29935)
2f9380e 
* test(e2e): add test case for path with '@'

* don't url encode in tests

* bump @gatsbyjs/reach-router

(cherry picked from commit 157ae16)
@vladar vladar moved this from To cherry-pick to Backport PR opened in V3 Release Hotfixes Mar 3, 2021
vladar pushed a commit that referenced this pull request Mar 3, 2021
@pieh
fix(gatsby): fix routing for paths with characters like @ etc (#29935…
03fd1cb 
…) (#29967)

* test(e2e): add test case for path with '@'

* don't url encode in tests

* bump @gatsbyjs/reach-router

(cherry picked from commit 157ae16)

Co-authored-by: Michal Piechowiak <misiek.piechowiak@gmail.com>
@vladar vladar moved this from Backport PR opened to Backported in V3 Release Hotfixes Mar 3, 2021
@vladar vladar moved this from Backported to Archived in V3 Release Hotfixes Mar 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wardpeet wardpeet wardpeet approved these changes

Assignees
No one assigned
Labels
None yet
Projects
No open projects
V3 Release Hotfixes
Published
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@pieh @wardpeet