fix(gatsby-source-wordpress): auto-rename types named "Filter" #29718
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gatsbot
bot
added
the
status: triage needed
TylerBarnes
changed the title
TylerBarnes
removed
the
status: triage needed
sslotsky
previously approved these changes
Feb 23, 2021
…-breaks-for-some-sites
sslotsky
previously approved these changes
Feb 25, 2021
…-breaks-for-some-sites
…-breaks-for-some-sites
…-breaks-for-some-sites
…-breaks-for-some-sites
…gatsbyjs/gatsby into fix/root-wp-field-breaks-for-some-sites
vladar
pushed a commit
that referenced
this pull request
Feb 27, 2021
Co-authored-by: gatsbybot <mathews.kyle+gatsbybot@gmail.com> (cherry picked from commit fb225be)
vladar
pushed a commit
that referenced
this pull request
Feb 27, 2021
ascorbic
pushed a commit
that referenced
this pull request
Mar 1, 2021
Co-authored-by: gatsbybot <mathews.kyle+gatsbybot@gmail.com> (cherry picked from commit fb225be)
This was referenced Mar 15, 2021
This was referenced Jul 21, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #29684
When a node type is named "Filter", Gatsby is using it's fields to make input args for some other fields. That should be fixed in core (https://gatsby.canny.io/ideas/p/node-types-named-filter-cause-graphql-input-arg-generation-problems) but in the meantime I've added a simple fix for WP users here.
The fix is https://github.com/gatsbyjs/gatsby/blob/fix/root-wp-field-breaks-for-some-sites/packages/gatsby-source-wordpress/src/steps/create-schema-customization/helpers.js#L23-L25
the other changes are a slight refactor to make debugging easier.