Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(conditional-page-builds): make it default #29548

Merged
merged 3 commits into from
Feb 18, 2021

Conversation

pieh
Copy link
Contributor

@pieh pieh commented Feb 17, 2021

Description

This removes GATSBY_EXPERIMENTAL_PAGE_BUILD_ON_DATA_CHANGES and makes the behaviour our default

[ch25068]

@pieh pieh added topic: SSG* topic: build Related to the Gatsby build process labels Feb 17, 2021
@gatsbot gatsbot bot added the status: triage needed Issue or pull request that need to be triaged and assigned to a reviewer label Feb 17, 2021
wardpeet
wardpeet previously approved these changes Feb 17, 2021
Copy link
Contributor

@wardpeet wardpeet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, small nits but nothing blocking

process.env.GATSBY_EXPERIMENTAL_PAGE_BUILD_ON_DATA_CHANGES &&
process.argv.includes(`--log-pages`)
) {
if (process.argv.includes(`--log-pages`)) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

shouldn't we move this to the cli? 😬
Can you create a follow up ticket?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, we probably already get things on program for it because we do let yargs know about them (just hide them from --help) -

// log-pages and write-to-file were added specifically to experimental GATSBY_EXPERIMENTAL_PAGE_BUILD_ON_DATA_CHANGES feature
// in gatsby@2. They are useful, but not very applicable (specifically `--write-to-file`) as generic approach, as it only
// list pages without other artifacts, so it's useful in very narrow scope. Because we don't have alternative right now
// those toggles are kept for users that rely on them, but we won't promote them and will keep them "hidden".
.option(`log-pages`, {
type: `boolean`,
default: false,
describe: `Log the pages that changes since last build.`,
hidden: true,
})
.option(`write-to-file`, {
type: `boolean`,
default: false,
describe: `Save the log of changed pages for future comparison.`,
hidden: true,
}),

I'll create follow up ticket on that

@wardpeet wardpeet removed the status: triage needed Issue or pull request that need to be triaged and assigned to a reviewer label Feb 17, 2021
Co-authored-by: Ward Peeters <ward@coding-tech.com>
vladar
vladar previously approved these changes Feb 17, 2021
@pieh pieh merged commit 348a5bf into master Feb 18, 2021
@pieh pieh deleted the make-conditional-page-builds-default branch February 18, 2021 10:19
pragmaticpat pushed a commit to pragmaticpat/gatsby that referenced this pull request Apr 28, 2022
* feat(build): conditional page builds are no longer experimental (they are default)

* Update docs/docs/conceptual/overview-of-the-gatsby-build-process.md

Co-authored-by: Ward Peeters <ward@coding-tech.com>

* fix cli integration tests

Co-authored-by: Ward Peeters <ward@coding-tech.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
topic: build Related to the Gatsby build process
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants