Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(gatsby-source-contentful): set default for contentful asset workers #27586

Merged
merged 2 commits into from Oct 21, 2020

Conversation

pvdz
Copy link
Contributor

@pvdz pvdz commented Oct 21, 2020

#27563 introduced a assetDownloadWorkers but the function that generated the workers could still receive undefined. This sets the default to make sure it's always getting some value.

@gatsbot gatsbot bot added the status: triage needed Issue or pull request that need to be triaged and assigned to a reviewer label Oct 21, 2020
@pvdz pvdz added bot: merge on green Gatsbot will merge these PRs automatically when all tests passes topic: source-contentful Related to Gatsby's integration with Contentful type: bug An issue or pull request relating to a bug in Gatsby and removed status: triage needed Issue or pull request that need to be triaged and assigned to a reviewer labels Oct 21, 2020
@wardpeet
Copy link
Contributor

I feel we should have a test for this

@pvdz
Copy link
Contributor Author

pvdz commented Oct 21, 2020

I'm not sure why the schema isn't taking care of the default but this is more of a hotfix than anything else.

@pvdz pvdz merged commit d372db8 into master Oct 21, 2020
@delete-merged-branch delete-merged-branch bot deleted the contentassetdefault branch October 21, 2020 13:52
@pvdz
Copy link
Contributor Author

pvdz commented Oct 22, 2020

Published in gatsby-source-contentful@3.0.3

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bot: merge on green Gatsbot will merge these PRs automatically when all tests passes topic: source-contentful Related to Gatsby's integration with Contentful type: bug An issue or pull request relating to a bug in Gatsby
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants