Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(gatsby-cli): Augment plugin errors with plugin name #27435

Merged
merged 4 commits into from Nov 6, 2020
Merged

feat(gatsby-cli): Augment plugin errors with plugin name #27435

merged 4 commits into from Nov 6, 2020

Conversation

julienp
Copy link
Contributor

@julienp julienp commented Oct 14, 2020 •
edited by sidharthachatterjee

This will ensure both structured and unstructured errors include a plugin name

@gatsbot gatsbot bot added the status: triage needed Issue or pull request that need to be triaged and assigned to a reviewer label Oct 14, 2020
@LekoArts LekoArts added topic: cli Related to the Gatsby CLI and removed status: triage needed Issue or pull request that need to be triaged and assigned to a reviewer labels Oct 15, 2020
@sidharthachatterjee sidharthachatterjee marked this pull request as ready for review November 6, 2020 12:56
@sidharthachatterjee sidharthachatterjee requested a review from a team as a code owner November 6, 2020 12:56
sidharthachatterjee
sidharthachatterjee approved these changes Nov 6, 2020
View reviewed changes
Copy link
Contributor

@sidharthachatterjee sidharthachatterjee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sidharthachatterjee sidharthachatterjee added the bot: merge on green Gatsbot will merge these PRs automatically when all tests passes label Nov 6, 2020
@gatsbybot gatsbybot merged commit 700d245 into gatsbyjs:master Nov 6, 2020
@vladar
Copy link
Contributor

vladar commented Nov 6, 2020

How it will look like (i.e. before and after)? I am thinking about adding a release note for this change.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sidharthachatterjee sidharthachatterjee sidharthachatterjee approved these changes

Assignees
No one assigned
Labels
bot: merge on green Gatsbot will merge these PRs automatically when all tests passes topic: cli Related to the Gatsby CLI
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@julienp @vladar @sidharthachatterjee @LekoArts @gatsbybot