New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add siteHash and userAgent #27170
Merged
Merged
Add siteHash and userAgent #27170
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gatsbot
bot
added
the
status: triage needed
Issue or pull request that need to be triaged and assigned to a reviewer
label
Sep 29, 2020
Gatsby Cloud Build Reportgatsby 🎉 Your build was successful! See the Deploy preview here. Build Details🕐 Build time: 19m |
mfrachet
previously approved these changes
Sep 30, 2020
LekoArts
added
topic: telemetry*
and removed
status: triage needed
Issue or pull request that need to be triaged and assigned to a reviewer
labels
Sep 30, 2020
ascorbic
previously approved these changes
Sep 30, 2020
jamo
added
the
bot: merge on green
Gatsbot will merge these PRs automatically when all tests passes
label
Sep 30, 2020
ascorbic
reviewed
Sep 30, 2020
jamo
force-pushed
the
oss-telemetry-part2
branch
from
September 30, 2020 11:57
0104c85
to
2a5eae6
Compare
ascorbic
reviewed
Oct 1, 2020
return | ||
} | ||
if (typeof tags.siteHash === `undefined`) { | ||
tags.siteHash = this.siteHash |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ooh, a place in the wild where ??=
is going to be useful when it lands!
ascorbic
approved these changes
Oct 1, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.