feat(gatsby-starter-blog): Remove typography.js #27001
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gatsbot
bot
added
the
status: triage needed
LekoArts
added
topic: starters
and removed
status: triage needed
Gatsby Cloud Build Reportgatsby 🎉 Your build was successful! See the Deploy preview here. Build Details🕐 Build time: 20m |
LekoArts
commented
Sep 23, 2020
| const saltyDuckEgg = "chinese preserved food product" | ||
| ``` | ||
|
|
||
| | Number | Title | Year | |
There was a problem hiding this comment.
Some boilerplate to test out all markdown combinations
LekoArts
commented
Sep 23, 2020
| {title} | ||
| </Link> | ||
| </h3> | ||
| <Link className="header-link-home" to="/"> |
There was a problem hiding this comment.
h3 wasn't the correct tag for this link (it always came before the h1 of the page)
LekoArts
commented
Sep 23, 2020
| to={post.fields.slug} | ||
| itemProp="url" | ||
| > | ||
| <h2> |
There was a problem hiding this comment.
Correct order of heading tags was h2 here
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This removes
typography.jsfrom the "blog" starter and replaces it with normal CSS files.Typography.js is proprietary, difficult to understand (if you never used it) and cumbersome to remove from the project. The starter shouldn't be too opinionated and include it by default. With normal CSS files users can quickly remove all styling and replace it with their own. This problem was often mentioned by users.
The overall style didn't change much (a complete redesign can be done in the future) so the custom CSS replicates the style.
Screenshots