fix(gatsby-remark-copy-linked-files): respect assetPrefix #26976
+112
−21
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ertions - it doesn't inspire confidence
gatsbot
bot
added
the
status: triage needed
pieh
added
topic: remark/mdx
pieh
commented
Sep 21, 2020
pieh
commented
Sep 21, 2020
Comment on lines
-310
to
+402
| `/undefined/undefined.gif` | ||
| fileLocationPart |
There was a problem hiding this comment.
this and other adjustments are not necessary for this PR, but as I looked to add cases for assetPrefix I noticed those undefined there in expecteted strings and thought that it doesn't inspire a lot of confidence in those tests so I adjusted tests to specify internal.contentDigest and name fields on File nodes so those are more specific assertions
Gatsby Cloud Build Reportgatsby 🎉 Your build was successful! See the Deploy preview here. Build Details🕐 Build time: 21m |
vladar
approved these changes
Sep 21, 2020
pieh
added
the
bot: merge on green
|
Successfully published:
|
pragmaticpat
pushed a commit
to pragmaticpat/gatsby
that referenced
this pull request
Apr 28, 2022
…6976) * test(gatsby-remarkc-copy-linked-files): get rid of "undefined" in assertions - it doesn't inspire confidence * fix(gatsby-remark-copy-linked-files): honor assetPrefix correctly Co-authored-by: gatsbybot <mathews.kyle+gatsbybot@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Function that generates urls in
gatsby-remark-copy-linked-filesis not compatible withassetPrefix- current path joining result in something like/https:/cdn.your-domain.com/{generated-hash-values}/demo.svg(note that first character in front of protocol part).This PR changes to URL generation to match what
gatsby-plugin-sharpalready do (which is just doing string manipulation, becausepathPrefixis already passing in form that allows for it - it strips trailing slash always, which means that using${prefix}/some/pathwill work correctly):gatsby/packages/gatsby-plugin-sharp/src/index.js
Lines 142 to 145 in 8ad565f
Related Issues
Fixes #25918