New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(gatsby): create telemetry service and start it during develop #26832
Conversation
Gatsby Cloud Build Reportusing-styled-components 🎉 Your build was successful! See the Deploy preview here. Build Details🕐 Build time: 19s PerformanceLighthouse report
|
Gatsby Cloud Build Reportclient-only-paths 🎉 Your build was successful! See the Deploy preview here. Build Details🕐 Build time: 20s PerformanceLighthouse report
|
Gatsby Cloud Build Reportusing-reach-skip-nav 🎉 Your build was successful! See the Deploy preview here. Build Details🕐 Build time: 20s PerformanceLighthouse report
|
Gatsby Cloud Build Reportgatsby 🎉 Your build was successful! See the Deploy preview here. Build Details🕐 Build time: 21m |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🤩
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we make this part of gatsby-admin and not part of telemetry?
Edit:
Sorry for the fast answer, I didn't want this merged before a discussion and I was heading into a meeting. Moving this to admin would make more sense cause it's the only user. This way we can keep telemetry small with fewer side effects.
Now that I think of it, telemetry itself should probably be a toolkit that allows us to track pieces but gatsby-cli/gatsby should do the setup/flushing, ...
Why did you add it to telemetry and not admin itself?
I put it in I'd be happy to physically move that file to |
My mistake, please move it to |
Done! Ready for a re-review @wardpeet 👍 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems to work :) Looking good
As we noticed in #26627, gatsby-telemetry can only run in a node context. In order to add telemetry to Admin we need to create a HTTP server that exposes the telemetry methods for Admin to POST to.
setGatsbyCliVersion
andsetDefaultComponentId