Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Tracking]: gatsby-image PRs waiting on review and merge #25487

Closed
3 of 7 tasks
polarathene opened this issue Jul 3, 2020 · 1 comment
Closed
3 of 7 tasks

[Tracking]: gatsby-image PRs waiting on review and merge #25487

polarathene opened this issue Jul 3, 2020 · 1 comment
Labels
status: needs core review Currently awaiting review from Core team member topic: media Related to gatsby-plugin-image, or general image/media processing topics type: maintenance An issue or pull request describing a change that isn't a bug, feature or documentation change type: question or discussion Issue discussing or asking a question about Gatsby

Comments

@polarathene
Copy link
Contributor

polarathene commented Jul 3, 2020

As these are starting to pile up and age, I created this issue to keep track of them.

I've tried reaching out several times for review to my PRs, and I've reviewed several others related to gatsby-image. @wardpeet is assigned to most, but seems to be rather busy lately with other work. I'd appreciate it if someone could spare the time to give these a look, especially #25325

Cheers.

Approved

I've reviewed these and would like to seem them merged.

Update: @wardpeet has reviewed and approved each one, two have been left unmerged however, would be great if someone with authority could merge those!

Pending changes

About a month since last activity, few days ago I reviewed and requested changes. If no activity after a while I'm happy to make the changes and recreate the PR, albeit waiting on core team about decision with how to approach ReactDOMServer. @pieh received no response since April 18.

Update: No feedback on this PR for 2 weeks since my activity there. I guess the ReactDOMServer approach isn't worth the time vs handling it with the v3 update where min React version can be raised.

Update: @wardpeet decided against merging this. I still disagree with that decision and suggested workaround, but that discussion appears to have stalled.

Personal PRs awaiting review

Several users are waiting on a fix for the hydration issue, while the base64 one is mostly docs so the feature can be actually discovered.

Update: Both have had an initial pass from @wardpeet but will need another review for changes, especially the hydration fix which added related fixes to art direction(I could separate these out into individual PRs if preferred).

@polarathene polarathene added the type: question or discussion Issue discussing or asking a question about Gatsby label Jul 3, 2020
@gatsbot gatsbot bot added the status: triage needed Issue or pull request that need to be triaged and assigned to a reviewer label Jul 3, 2020
@polarathene polarathene added status: needs core review Currently awaiting review from Core team member topic: media Related to gatsby-plugin-image, or general image/media processing topics topic: sharp type: maintenance An issue or pull request describing a change that isn't a bug, feature or documentation change and removed status: triage needed Issue or pull request that need to be triaged and assigned to a reviewer labels Jul 3, 2020
@wardpeet
Copy link
Contributor

wardpeet commented Jul 3, 2020

Hey,

Thanks @polarathene, we have labels in place to make sure we catch all of these issues so this is a bit unnecessary.

Thanks for understanding!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status: needs core review Currently awaiting review from Core team member topic: media Related to gatsby-plugin-image, or general image/media processing topics type: maintenance An issue or pull request describing a change that isn't a bug, feature or documentation change type: question or discussion Issue discussing or asking a question about Gatsby
Projects
None yet
Development

No branches or pull requests

2 participants