chore(gatsby): Drop (experimental) support for Loki #23838
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gatsbot
bot
added
the
status: triage needed
pvdz
removed
the
status: triage needed
pvdz
force-pushed
the
drop-loki
branch
2 times, most recently
from
59c7287
to
b276ca0
Compare
This time I did a `grep -r --exclude-dir=node_modules --exclude-dir=.git loki`
pvdz
force-pushed
the
drop-loki
branch
2 times, most recently
from
ebb6f46
to
3d58ecb
Compare
pieh
approved these changes
May 8, 2020
|
👋 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Loki was already disabled last week. This PR will only drop the code related to Loki.
Closes #17935
I've had to disable a recipe yarn test becase it was failing for reasons unknown and I couldn't easily see why or whether it related to this PR. After a few hours I disabled this and will pass this on to the team responsible.