Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(babel-preset-gatsby): add @babel/plugin-transform-spread as dependencies #15714

Merged

Conversation

weareoutman
Copy link
Contributor

Description

#15172 introduced @babel/plugin-transform-spread in babel-preset-gatsby, this will cause build errors if using a custom .babelrc, since it's not a dependency of babel-preset-gatsby.

We should add @babel/plugin-transform-spread as dependencies of babel-preset-gatsby.

[BABEL] /PROJECT-DIR/.cache/production-app.js: Cannot find module '@babel/plugin-transform-spread' (While processing: "/PROJECT-DIR/node_modules/babel-preset-gatsby/index.js")

Related Issues

@weareoutman weareoutman requested a review from a team as a code owner July 15, 2019 05:45
@weareoutman weareoutman force-pushed the fix-deps-of-babel-preset-gatsby branch from e9d4306 to 12db470 Compare July 15, 2019 05:48
@weareoutman weareoutman force-pushed the fix-deps-of-babel-preset-gatsby branch from 12db470 to ee4e268 Compare July 15, 2019 05:53
Copy link
Contributor

@pieh pieh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, You are of course right. Sorry for inconvenience and thanks for fix!

@pieh pieh added the bot: merge on green Gatsbot will merge these PRs automatically when all tests passes label Jul 15, 2019
@gatsbybot gatsbybot merged commit dfde933 into gatsbyjs:master Jul 15, 2019
@gatsbot
Copy link

gatsbot bot commented Jul 15, 2019

Holy buckets, @weareoutman — we just merged your PR to Gatsby! 💪💜

Gatsby is built by awesome people like you. Let us say “thanks” in two ways:

  1. We’d like to send you some Gatsby swag. As a token of our appreciation, you can go to the Gatsby Swag Store and log in with your GitHub account to get a coupon code good for one free piece of swag. We’ve got Gatsby t-shirts, stickers, hats, scrunchies, and much more. (You can also unlock even more free swag with 5 contributions — wink wink nudge nudge.) See gatsby.dev/swag for details.
  2. We just invited you to join the Gatsby organization on GitHub. This will add you to our team of maintainers. Accept the invite by visiting https://github.com/orgs/gatsbyjs/invitation. By joining the team, you’ll be able to label issues, review pull requests, and merge approved pull requests.

If there’s anything we can do to help, please don’t hesitate to reach out to us: tweet at @gatsbyjs and we’ll come a-runnin’.

Thanks again!

madmonkey pushed a commit to madmonkey/gatsby that referenced this pull request Jul 15, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bot: merge on green Gatsbot will merge these PRs automatically when all tests passes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants