Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't silently process.exit #12042

Closed
stefanprobst opened this issue Feb 24, 2019 · 6 comments
Closed

Don't silently process.exit #12042

stefanprobst opened this issue Feb 24, 2019 · 6 comments
Labels
status: confirmed Issue with steps to reproduce the bug that’s been verified by at least one reviewer. type: bug An issue or pull request relating to a bug in Gatsby
Projects

Comments

@stefanprobst
Copy link
Contributor

Calling process.exit without an error message is really hard to debug.

@KyleAMathews
Copy link
Contributor

Hmm I have no idea why that's there. And yeah, it doesn't make any sense.

Luckily my almost ready to go PR just removed that file.

#11897

@freiksenet
Copy link
Contributor

process.exit also fails very annoyingly in jest tests (hanging jest infinitely). Should we fix that too?

@freiksenet freiksenet added type: bug An issue or pull request relating to a bug in Gatsby status: confirmed Issue with steps to reproduce the bug that’s been verified by at least one reviewer. labels Feb 25, 2019
@gatsbot gatsbot bot added the stale? Issue that may be closed soon due to the original author not responding any more. label Mar 18, 2019
@gatsbot
Copy link

gatsbot bot commented Mar 18, 2019

Hiya!

This issue has gone quiet. Spooky quiet. 👻

We get a lot of issues, so we currently close issues after 30 days of inactivity. It’s been at least 20 days since the last update here.

If we missed this issue or if you want to keep it open, please reply here. You can also add the label "not stale" to keep this issue open!

Thanks for being a part of the Gatsby community! 💪💜

@stefanprobst stefanprobst added not stale and removed stale? Issue that may be closed soon due to the original author not responding any more. labels Mar 18, 2019
@wardpeet
Copy link
Contributor

We should move to process.exitCode instead. I think it's a good idea to handle this inside gatsbyjs/rfcs#31

@freiksenet freiksenet added this to To prioritize in OSS Roadmap via automation Jun 25, 2019
@KyleAMathews
Copy link
Contributor

Oh this is fixed now.

OSS Roadmap automation moved this from To prioritize to Done Jun 28, 2019
@KyleAMathews
Copy link
Contributor

The linked file doesn't exist anymore

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status: confirmed Issue with steps to reproduce the bug that’s been verified by at least one reviewer. type: bug An issue or pull request relating to a bug in Gatsby
Projects
No open projects
OSS Roadmap
  
Done
Development

No branches or pull requests

5 participants