Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gatsby site freezes after swiping to go back in Safari iOS 12.2 Beta #11355

Closed
slk333 opened this issue Jan 28, 2019 · 10 comments
Closed

Gatsby site freezes after swiping to go back in Safari iOS 12.2 Beta #11355

slk333 opened this issue Jan 28, 2019 · 10 comments
Labels
status: needs more info Needs triaging and reproducible examples or more information to be resolved type: upstream Issues outside of Gatsby's control, caused by dependencies

Comments

@slk333
Copy link
Contributor

slk333 commented Jan 28, 2019

edit: I realized after making this issue that it's only on iOS 12.2 Beta, so maybe it's the fault of Apple.
iOS 12.2 Beta makes the ancient bug come back:

#2842

15486954421812622

Currently on every Gatsby site, when swiping to go back in mobile safari, the screen freezes up and sometimes goes blank for ~2-6 seconds. This really breaks the flow of the site.

As soon as the page go backs I try to scroll, but its completely frozen (until that highlighted state on the button goes away).

@slk333 slk333 changed the title Gatsby site freezes after swiping to go back in iOS Safari Gatsby site freezes after swiping to go back in iOS Safari iPhone X Jan 28, 2019
@sidharthachatterjee sidharthachatterjee added the status: needs more info Needs triaging and reproducible examples or more information to be resolved label Jan 28, 2019
@sidharthachatterjee
Copy link
Contributor

I can't seem to reproduce this on http://gatsbyjs.org on my iPhone X running iOS 12.1.3

As far as I know, this was fixed in taion/scroll-behavior#129

@sidharthachatterjee
Copy link
Contributor

Can also confirm that scrollRestoration is set to auto
screenshot 2019-01-28 22 17 31

@slk333
Copy link
Contributor Author

slk333 commented Jan 28, 2019

from the tests I've made, this freeze only appear on iOS 12.2 Beta(I've tested iOS 12.1 and 12.2 simulators, problem only appears on iOS 12.2)
Thank you for your feedback @sidharthachatterjee
What could I do from here?
Is the problem only attributed to Apple?

@slk333 slk333 changed the title Gatsby site freezes after swiping to go back in iOS Safari iPhone X Gatsby site freezes after swiping to go back in iOS Safari iOS 12.2 Beta Jan 28, 2019
@sidharthachatterjee sidharthachatterjee added the type: upstream Issues outside of Gatsby's control, caused by dependencies label Jan 28, 2019
@slk333
Copy link
Contributor Author

slk333 commented Jan 28, 2019

15486954421812622

@sidharthachatterjee
Copy link
Contributor

The issue at #2842 was an iOS Safari bug so yes, looks like this is specific to iOS.

Haven't tested this on the iOS 12.2 beta yet.

@slk333 slk333 changed the title Gatsby site freezes after swiping to go back in iOS Safari iOS 12.2 Beta Gatsby site freezes after swiping to go back in Safari iOS 12.2 Beta Jan 28, 2019
@hippotastic
Copy link

Can you please send us the output of this site using the browser that you experience the freezing issue on?

https://www.w3schools.com/jsref/tryit.asp?filename=tryjsref_nav_all

It just outputs all navigator object properties. This may help as the freezing fix unfortunately had to rely on browser detection, which uses some of these properties.

@slk333
Copy link
Contributor Author

slk333 commented Jan 29, 2019

Hi and thanks for the reply, @rutzfutz

Browser CodeName: Mozilla

Browser Name: Netscape

Browser Version: 5.0 (iPhone; CPU iPhone OS 12_2 like Mac OS X) AppleWebKit/605.1.15 (KHTML, like Gecko) Version/12.1 Mobile/15E148 Safari/604.1

Cookies Enabled: true

Browser Language: en-US

Browser Online: true

Platform: iPhone

User-agent header: Mozilla/5.0 (iPhone; CPU iPhone OS 12_2 like Mac OS X) AppleWebKit/605.1.15 (KHTML, like Gecko) Version/12.1 Mobile/15E148 Safari/604.1

@hippotastic
Copy link

Thank you. Your browser is still identified correctly by the detection we added in taion/scroll-behavior#129, so this part of the scroll-behavior package is unlikely to cause the freeze you're encountering, as it's not setting window.history.scrollRestoration in your scenario.

The bug must lie somewhere else. Sorry not to be of more help!

@slk333
Copy link
Contributor Author

slk333 commented Jan 29, 2019

Yes, hopefully this will be fixed by Apple before iOS 12.2 ships. I don't know if we should keep the issue open in the mean time. I can open a new one if ever the bug still remains when iOS 12.2 ships (out of beta)

@sidharthachatterjee
Copy link
Contributor

Let's close the issue for now @slk333 since it affects beta iOS. Please feel free to reopen on release if this still occurs. Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status: needs more info Needs triaging and reproducible examples or more information to be resolved type: upstream Issues outside of Gatsby's control, caused by dependencies
Projects
None yet
Development

No branches or pull requests

3 participants