Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modify installation and exposing of .mplstyles #69

Merged
merged 6 commits into from Nov 6, 2022

Conversation

echedey-ls
Copy link
Collaborator

@echedey-ls echedey-ls commented Sep 25, 2022

Major changes

Minor changes

  • Update .gitignore
  • Bump version to 1.1.0

Requires updating Wiki and other docs.

Closes #68
Should close #61 too

I'd like as much input as possible.
I've been working on it for some time now and done some broad testing, but before breaking anything I'd like someone else to install from my repo and look for any flaws.

Hope this helps.

* Change distribution scheme similar to https://github.com/dhaitz/mplcyberpunk
 - Clears copy of files to .matplolib/styles
* Bump version to 1.1.0
Dunno how I messed up the GH Desktop selections duh
Now you got everything although commented
@garrettj403
Copy link
Owner

Hi @echedey-ls

Thanks for putting so much work into this! I always felt that my setup.py file was pretty hacky.

I was able to install from your fork without any issue. Just a couple minor tweaks:

  1. Please change the package name to scienceplots (lower-case). That way we import by import scienceplots and not import SciencePlots.
  2. Please add import scienceplots to the top of plot-examples.py.

@garrettj403 garrettj403 merged commit a508b4c into garrettj403:master Nov 6, 2022
@echedey-ls
Copy link
Collaborator Author

Hi, thanks for the feedback.
I see I'm a bit late to tell you what I did, haha.

I didn't want to change name (in setup.py) because I think that would mess up the pypi distribution. But as you can see, the rest of SciencePlots have been changed to scienceplots. Tested and it's working on my machine.

As a sidenote, I changed the version bump I did to the current one 1.0.9, so the changelog can be modified at convenience.

Thanks for your work too.

@echedey-ls echedey-ls added the enhancement New feature or request label Jan 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Proposal & discussion to use other distribution model Use setup.py build system
2 participants