Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Accept type string for location and address #1122

Merged
merged 1 commit into from Dec 3, 2022

Conversation

nandenjin
Copy link
Contributor

@nandenjin nandenjin commented Dec 3, 2022

Description of Change(s):

Fixes #1116

  • type Location now includes string (cf: location)
  • type Address now includes string (cf: address)
  • setLocation() and setAddress return string itself for parameters with type string
  • Add unit tests

To help get PR's merged faster, the following is required:

  • Updated the documentation
  • Unit/Cypress test covering all cases

Please link to relevant Google Docs or schema.org docs for what you are adding so we can review.

Please have a read of the Contributing Guide for full details.

https://github.com/garmeeh/next-seo/blob/master/CONTRIBUTING.md

Copy link
Owner

@garmeeh garmeeh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you 😄

@garmeeh garmeeh merged commit 0dbcef4 into garmeeh:master Dec 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Types location and address should accept simple Text type
2 participants