Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: enhance NewsArticleJsonLd and ArticleJsonLd author #1105

Merged
merged 1 commit into from Dec 3, 2022

Conversation

ilyichv
Copy link
Contributor

@ilyichv ilyichv commented Nov 21, 2022

Description of Change(s):

NewsArticleJsonLd author couldn't be customised with @type and url parameter.
With this PR NewsArticleJsonLd authorName prop accepts also ArticleAuthor.

Also there was no way to override @type property of author. With this PR the default is set to Person but can be customised.


To help get PR's merged faster, the following is required:

[] Updated the documentation
[x] Unit/Cypress test covering all cases

Please link to relevant Google Docs or schema.org docs for what you are adding so we can review.

Please have a read of the Contributing Guide for full details.

https://github.com/garmeeh/next-seo/blob/master/CONTRIBUTING.md

@ilyichv ilyichv changed the title feat: enhance NewsArticleJsonLd author feat: enhance NewsArticleJsonLd and ArticleJsonLd author Nov 23, 2022
@garmeeh
Copy link
Owner

garmeeh commented Dec 3, 2022

Hey @ilyichv thank you for the PR. Would you mind updating the documentation for this and I can get this merged and released.

Copy link
Owner

@garmeeh garmeeh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No sense in holding this up over a small piece of documentation, so will merge and release.

@garmeeh garmeeh merged commit 9409826 into garmeeh:master Dec 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants