Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove keyoverride attribute from additional meta tags #1080

Merged
merged 2 commits into from Nov 4, 2022
Merged

Remove keyoverride attribute from additional meta tags #1080

merged 2 commits into from Nov 4, 2022

Conversation

ediblecode
Copy link
Contributor

Description of Change(s):

Fixes #1079.

  • Stops the keyOverride prop for additionalMetaTags being rendered as a keyoverride attribute.
  • Improves the readme around the keyOverride prop

garmeeh
garmeeh approved these changes Nov 4, 2022
View reviewed changes
Copy link
Owner

@garmeeh garmeeh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is much better documentation! Thank you for taking the time to log the detailed issue and then fix it 🙏

@garmeeh garmeeh merged commit 37dda3c into garmeeh:master Nov 4, 2022
@ediblecode
Copy link
Contributor Author

Well thank you @garmeeh for an awesome project!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@garmeeh garmeeh garmeeh approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

keyOverride prop rendering as an attribute on meta tags
2 participants
@ediblecode @garmeeh