Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding email property to the ContactPoint type #1069

Merged
merged 5 commits into from Nov 9, 2022

Conversation

sam-meehan7
Copy link
Contributor

@sam-meehan7 sam-meehan7 commented Oct 28, 2022

Description of Change(s):

fixes #1055


To help get PR's merged faster, the following is required:

[x] Updated the documentation
[x] Unit/Cypress test covering all cases

Please link to relevant Google Docs or schema.org docs for what you are adding so we can review.

Please have a read of the Contributing Guide for full details.

https://github.com/garmeeh/next-seo/blob/master/CONTRIBUTING.md

Copy link
Owner

@garmeeh garmeeh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉 Nice one

Copy link
Owner

@garmeeh garmeeh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some small changes. Formatted may be off due to suggestions being added via Github UI so maybe add directly via your code editor.

src/jsonld/organization.tsx Outdated Show resolved Hide resolved
src/jsonld/organization.tsx Outdated Show resolved Hide resolved
src/jsonld/organization.tsx Outdated Show resolved Hide resolved
cypress/e2e/organization.spec.js Outdated Show resolved Hide resolved
@edoardolincetto
Copy link
Contributor

Hi @garmeeh, I've seen your suggestions above about the deprecation of the contactPoints prop, and just for completeness, I've implemented them on PR #1070 (which is dedicated to fixing issue #925). 👨🏻‍💻

@garmeeh garmeeh merged commit f857eb5 into garmeeh:master Nov 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ContactPoint has missing properties
3 participants