Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Optimize CI a bit #452

Merged
merged 7 commits into from Mar 27, 2022
Merged

Optimize CI a bit #452

merged 7 commits into from Mar 27, 2022

Conversation

Goooler
Copy link
Contributor

@Goooler Goooler commented Mar 19, 2022

No description provided.

@CLAassistant
Copy link

CLAassistant commented Mar 19, 2022

CLA assistant check
All committers have signed the CLA.

@@ -50,14 +56,16 @@ jobs:
deploy:
name: Maven deploy
runs-on: ubuntu-18.04
if: github.repository == 'gantsign/ktlint-maven-plugin'
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Comment on lines 32 to 37
- uses: actions/cache@v2
with:
java-version: '1.8'
path: ~/.m2
key: ${{ runner.os }}-maven-${{ hashFiles('**/pom.xml') }}
restore-keys: |
${{ runner.os }}-maven-
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@codecov
Copy link

codecov bot commented Mar 19, 2022

Codecov Report

Merging #452 (5ee89ce) into master (b017f82) will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##             master     #452   +/-   ##
=========================================
  Coverage     85.34%   85.34%           
  Complexity       91       91           
=========================================
  Files            16       16           
  Lines           539      539           
  Branches         71       71           
=========================================
  Hits            460      460           
  Misses           34       34           
  Partials         45       45           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b017f82...5ee89ce. Read the comment docs.

Copy link
Member

@freemanjp freemanjp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, for the pull request, but I'd prefer to use the temurin JDK and remove the caching (see review comments for details).

.github/workflows/build.yml Outdated Show resolved Hide resolved
.github/workflows/build.yml Outdated Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants