Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some operator definitions are missing #129

Open
lesquoyb opened this issue Jan 17, 2023 · 2 comments
Open

Some operator definitions are missing #129

lesquoyb opened this issue Jan 17, 2023 · 2 comments

Comments

@lesquoyb
Copy link
Collaborator

lesquoyb commented Jan 17, 2023

Describe the bug
Some operators/statements with multiple definitions are missing one (or more?) of those definitions.
One example was given in this discussion, but I'm sure I already encountered other cases though didn't take the time to write them down.

To reproduce

  1. got to to_rectangles documentation
  2. see that the definition of to_rectangles (geometry, point) ---> list<geometry> is not present though it is available in gama

Additional context
Looking at the code of the operator, my guess would be that at the generation of the documentation only the first element of the value array is taken into account.

@lesquoyb lesquoyb added Bug 🐛 GAMA Generation ⚙ Problem coming from GAMA inbuilt documentation generation, fix have to be done on the Java code side labels Jan 17, 2023
@RoiArthurB RoiArthurB added Enhancement 🤗 Improve content ✒️ and removed GAMA Generation ⚙ Problem coming from GAMA inbuilt documentation generation, fix have to be done on the Java code side labels Jan 30, 2023
@lesquoyb lesquoyb added this to To fix in Gama 1.9.1 Feb 27, 2023
@benoitgaudou
Copy link
Contributor

In fact, when we have a case where the same method can be called from 2 different operators, the documentation is generated only for the first one, and in the second one there is only a reference to the first one (see any and one_of).

In the case of to_rectangles, we have an unexpected mix between common definition with split_geometry and independent definition...

@lesquoyb
Copy link
Collaborator Author

lesquoyb commented Mar 2, 2023

Is there a way to fix it so we have the definitions for both split_geometry and to_rectangles ? I also see in the examples of split_geometry that there's a third one: to_squares that is not even referenced.
Makes me think that for gama 2 we may need to find a better way to define alternative names for operators

@lesquoyb lesquoyb removed this from To fix in Gama 1.9.1 Apr 10, 2023
@lesquoyb lesquoyb changed the title Missing operator definitions Some operator definitions are missing Oct 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Todo
Development

No branches or pull requests

3 participants