Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop "Send to cloud" tool and associated cloudauthz code #18098

Closed
mvdbeek opened this issue May 6, 2024 · 1 comment · Fixed by #18196
Closed

Drop "Send to cloud" tool and associated cloudauthz code #18098

mvdbeek opened this issue May 6, 2024 · 1 comment · Fixed by #18196
Assignees
Labels
area/backend area/objectstore area/UI-UX kind/refactoring cleanup or refactoring of existing code, no functional changes planning

Comments

@mvdbeek
Copy link
Member

mvdbeek commented May 6, 2024

Opening this to make sure I'm not missing a reason why would need to keep any of this around:

https://github.com/galaxyproject/galaxy/blob/release_24.0/tools/data_export/send.xml and associated authz plumbing should probably be removed. I don't think it ever gained any adoption, there's no test or documentation, and what it is aiming to do we can do with file sources in a more generic way. None of this is needed for #15875, but I think it was created specifically for that purpose and doesn't look like it aligns with how we're going to want to bring user-defined object stores and file sources in the future.

Things we can remove:

Removing this would also make it slightly easier to refactor _get_authnz_backend and its usage so we can discriminate between real exceptions and expected noise (i.e. we didn't find a disabled provider)

@mvdbeek mvdbeek added planning area/UI-UX kind/refactoring cleanup or refactoring of existing code, no functional changes area/objectstore area/backend labels May 6, 2024
@mvdbeek mvdbeek changed the title Drop "Send to cloud" tool and associate authz code Drop "Send to cloud" tool and associate cloudauthz code May 6, 2024
@mvdbeek mvdbeek changed the title Drop "Send to cloud" tool and associate cloudauthz code Drop "Send to cloud" tool and associated cloudauthz code May 6, 2024
@dannon
Copy link
Member

dannon commented May 21, 2024

Yes, we should clean this up.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/backend area/objectstore area/UI-UX kind/refactoring cleanup or refactoring of existing code, no functional changes planning
Development

Successfully merging a pull request may close this issue.

3 participants