Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Galaxy does not show a blank first line in dataset peek for fasta files, MSA visualisation fails #18066

Open
hexylena opened this issue Apr 29, 2024 · 1 comment

Comments

@hexylena
Copy link
Member

hexylena commented Apr 29, 2024

This took a while to track down, big thanks to @wm75 for noticing the issue (https://github.com/usegalaxy-eu/issues/issues/522)

When a fasta file is uploaded to Galaxy that includes a blank first line it is correctly detected as a fasta file, however certain tools will break (namely the MSA visualisation). Many tools will process this file happily, but not the MSA visualisation.

It is not easy to detect this issue as Galaxy does not make it obvious there's a blank line:

Peek Preview
image image

[as a user] In the preview is that a suspicious amount of whitespace? or do the UI devs just want more whitespace because that's the current design trend? Did they just want to line it up with the upload button? (folks love lining stuff up), or is that just space that would be occupied by a column header if it was there? I don't know. But selecting the text doesn't make it obvious there's a line there, I don't know how I'd know where the text was supposed to start.

Perhaps line numbers in the preview would be a good solution here? Additionally retaining whitespace in the peek would be helpful and make it very clear (due to the very small padding around the element, a whole blank line would be very obvious.)

Perhaps also the MSA visualisation should be updated to .strip() or similar to enable it to handle what other tools consider as valid fasta files. Also which github should I contact them on? From that error message I have no idea and no way to find out.

image

I'm filling this as a feature, but I guess if I was thinking about this as a user I think this is a bug, that it's not obvious to me as a user why tools fail.

@hexylena
Copy link
Member Author

Please let me know if I should split this into three issues, one for preview, one for peek, and one for MSA or so.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants