Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New visual state for "purged-but-not-deleted" history items for scratch storage #18062

Open
natefoo opened this issue Apr 26, 2024 · 3 comments

Comments

@natefoo
Copy link
Member

natefoo commented Apr 26, 2024

Now that we're using "scratch storage" on usegalaxy.org, people are going to start regularly having history items deleted and purged that they did not delete themselves. This is likely to cause some confusion as a dataset that is there one day may be gone the next. A long time ago, the cleanup scripts used to not mark HDAs deleted when purging them so they'd still appear in the history as the user had left them. This was changed to make HDAs follow the same logical progression as all other objects in the DB: first mark deleted, then mark purged.

I propose that we revert to the old behavior (with an above-the-fold purged indicator on history items), although we can add a new column to differentiate between user-deleted and admin-deleted if we want to retain the logical ordering of deleted -> purged.

We could also add an additional annotation to the object store config that indicates how many days data are kept in that particular backend, which would allow for additional visual indication that a history item's days are numbered. Currently the only place you specify this in a non-descriptive way is as an argument to the pgcleanup script, so there's no direct way for Galaxy to know this.

@nsoranzo
Copy link
Member

I like the idea of using the object store config, in particular we could display an "expiry date" for each dataset. With that information shown, it's not that important for a user to know if an expired and purged dataset was deleted by them or by an admin script.

@mvdbeek
Copy link
Member

mvdbeek commented May 7, 2024

From backend meeting, track who and why a dataset was deleted or purged. Purged but not deleted seems ok to use as a visual indicator. yes to formally track cleanup time on object store config.

@natefoo
Copy link
Member Author

natefoo commented May 14, 2024

Purged but not deleted seems ok to use as a visual indicator.

Was this discussed from a technical level (i.e. what columns we should use)?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Triage/Discuss
Development

No branches or pull requests

3 participants