Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

4844 rlp encoding not working #2745

Open
ZanCorDX opened this issue Feb 20, 2024 · 0 comments
Open

4844 rlp encoding not working #2745

ZanCorDX opened this issue Feb 20, 2024 · 0 comments
Labels
bug Something isn't working

Comments

@ZanCorDX
Copy link

ZanCorDX commented Feb 20, 2024

https://github.com/gakonst/ethers-rs/blob/master/ethers-core/src/types/transaction/response.rs (checked at 73e5de2)
line 159 (Transaction::rlp()):
match self.transaction_type {
has missing the new tx type branch (3) and fallback on
// Legacy (0x00)
_ => {

@ZanCorDX ZanCorDX added the bug Something isn't working label Feb 20, 2024
@ZanCorDX ZanCorDX changed the title 4844 rlp decoding not working 4844 rlp encoding not working Feb 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant