Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Documentation is seriously outdated #2734

Open
iajoiner opened this issue Feb 12, 2024 · 2 comments
Open

Documentation is seriously outdated #2734

iajoiner opened this issue Feb 12, 2024 · 2 comments
Labels
bug Something isn't working

Comments

@iajoiner
Copy link

iajoiner commented Feb 12, 2024

Version
2.0.13

Platform
NA

Description
Block in https://github.com/gakonst/ethers-rs/blob/ethers-v2.0.13/ethers-core/src/types/block.rs and https://docs.rs/ethers/2.0.13/ethers/core/types/struct.Block.html do not have the same number of fields

@iajoiner iajoiner added the bug Something isn't working label Feb 12, 2024
@DaniPopes
Copy link
Collaborator

Documentation is not outdated, it's built with --all-features, which excludes all the #[cfg(not(feature = "celo"))] fields.

@iajoiner
Copy link
Author

iajoiner commented Feb 12, 2024

@DaniPopes I see. Well then we need it to be mentioned. Most users are not using it for Celo so non-Celo-only fields still need to be included. Ideally we should have whether one is on Celo toggleable in the documentation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants