Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement encoding and signing for EIP-4844 transaction requests #2719

Open
Rjected opened this issue Jan 30, 2024 · 1 comment
Open

Implement encoding and signing for EIP-4844 transaction requests #2719

Rjected opened this issue Jan 30, 2024 · 1 comment

Comments

@Rjected
Copy link
Contributor

Rjected commented Jan 30, 2024

Is your feature request related to a problem? Please describe.
Currently it is not possible to implement something like cast send --blob, because ethers-rs does not support signing and RLP encoding an EIP4844 transaction request.

Describe the solution you'd like
A new typed transaction request type should be implemented which has correct RLP encoding. This should be feature gated behind a new feature flag kzg, since c-kzg will need to be pulled in as a dependency.

This should support encoding for:

  • signing, and
  • eth_sendRawTransaction encoding

Additional context
An existing implementation of this can be found here:
https://github.com/paradigmxyz/reth/blob/34004938415a449c773530d5fb3ff3a99b099ace/crates/primitives/src/transaction/eip4844.rs#L315-L321

https://github.com/paradigmxyz/reth/blob/34004938415a449c773530d5fb3ff3a99b099ace/crates/primitives/src/transaction/eip4844.rs#L295-L306

https://github.com/paradigmxyz/reth/blob/34004938415a449c773530d5fb3ff3a99b099ace/crates/primitives/src/transaction/sidecar.rs#L101-L127

@yjhmelody
Copy link
Contributor

I think also need to support the codec for block new fields

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants