Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Terminal Links dont work #82

Open
hipstersmoothie opened this issue Oct 2, 2018 · 2 comments
Open

Terminal Links dont work #82

hipstersmoothie opened this issue Oct 2, 2018 · 2 comments

Comments

@hipstersmoothie
Copy link

I am trying to use https://github.com/sindresorhus/terminal-link

First I got the error

(node:6881) UnhandledPromiseRejectionWarning: Error: Table data must not contain control characters.
    at validateTableData (/Users/alisowski/Documents/perf-table/node_modules/table/dist/validateTableData.js:62:19)
    at table (/Users/alisowski/Documents/perf-table/node_modules/table/dist/table.js:95:34)
    at Object.<anonymous> (/Users/alisowski/Documents/perf-table/dist/index.js:221:36)
    at step (/Users/alisowski/Documents/perf-table/dist/index.js:43:23)
    at Object.next (/Users/alisowski/Documents/perf-table/dist/index.js:24:53)
    at fulfilled (/Users/alisowski/Documents/perf-table/dist/index.js:15:58)
    at process._tickCallback (internal/process/next_tick.js:68:7)

After commenting out the code that threw the error It output

screen shot 2018-10-02 at 11 37 33 am

Do you think it will be possible to terminal links inside of the table?

@gajus
Copy link
Owner

gajus commented Oct 3, 2018

This should be straightforward – just whitelist the control characters used to create the terminal links.

Would accept a PR.

@veronQ
Copy link

veronQ commented Aug 8, 2019

Is this fixed?
Could someone provide an example?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants