Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

emoji cause table column width corruption #67

Open
unjello opened this issue May 9, 2018 · 6 comments
Open

emoji cause table column width corruption #67

unjello opened this issue May 9, 2018 · 6 comments

Comments

@unjello
Copy link

unjello commented May 9, 2018

Emojis in cell text cause column width corruption:

corrupted table

stringWidth for ie. 24.2⚠️ returns 6. I am not Unicode expert, but this is most likely related to ZWJ code points and issue in string-width dependency: sindresorhus/string-width#2. Since that issue is almost 2 years old, maybe a different module should be used or own approach implemented?

@unjello unjello changed the title emoji cause table to emoji cause table column width corruption May 9, 2018
@lvleihere
Copy link

so, done?

@lvleihere
Copy link

Emojis in cell text cause column width corruption:

corrupted table

stringWidth for ie. 24.2⚠️ returns 6. I am not Unicode expert, but this is most likely related to ZWJ code points and issue in string-width dependency: sindresorhus/string-width#2. Since that issue is almost 2 years old, maybe a different module should be used or own approach implemented?

woo ~ I have the same problem. How did you solve it ?

@tklovett
Copy link

I just encountered this issue – ℹ️ and 🔥 are treated as different widths. I had them in different rows, same column.

@gajus
Copy link
Owner

gajus commented Nov 26, 2019

This issue is dependent on sindresorhus/string-width#2

We can switch packages if there is a better alternative.

@cruzdanilo
Copy link

what about power-assert-util-string-width?

@WaldoJeffers
Copy link

The issue seems to have been fixed a while ago in sindresorhus/string-width#39
Would it be possible to update the dependency on this lib in table?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

7 participants