Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Borderless Demo in Readme Possibly Erroneous #30

Open
shellscape opened this issue Dec 9, 2016 · 3 comments
Open

Borderless Demo in Readme Possibly Erroneous #30

shellscape opened this issue Dec 9, 2016 · 3 comments

Comments

@shellscape
Copy link

I copied and pasted the borderless demo from the README verbatim and it's printing empty lines between rows, which seems to run contrary to the expected output according to that section in the README. Here's my output:

→ node table-test.js

0A 0B 0C 

1A 1B 1C 

2A 2B 2C 

Does the README and the section on borderless tables need updating?

@shellscape shellscape changed the title Borderless Demo in Readme Possible Erroneous Borderless Demo in Readme Possibly Erroneous Dec 9, 2016
@gajus
Copy link
Owner

gajus commented Dec 9, 2016

Does the README and the section on borderless tables need updating?

Unsure. It could be a bug. (Its the only example thats not included in the ./test cases as far as I can see).

Have you tried tracing the code?

@shellscape
Copy link
Author

I haven't tried to debug it as yet. Evaluating a slew of similar modules at the moment.

@lipsumar
Copy link

lipsumar commented Apr 7, 2017

The doc seems wrong indeed, it's not
drawJoin: () => false, it's drawHorizontalLine: () => false

GantMan added a commit to GantMan/table that referenced this issue Nov 12, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants