Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Performance issue with large tables #223

Closed
m-allanson opened this issue Feb 25, 2024 · 1 comment
Closed

Performance issue with large tables #223

m-allanson opened this issue Feb 25, 2024 · 1 comment

Comments

@m-allanson
Copy link
Contributor

m-allanson commented Feb 25, 2024 •
edited

table is very slow for large tables.

On a recent Apple machine, it takes over 12 seconds to generate a 3256 row table.

Steps to reproduce

Use this repo: https://github.com/m-allanson/table-profile

Further notes

If you load a CPU Profile into SpeedScope, you can see that findOriginalRowIndex accounts for 94% of the running time:

CleanShot 2024-02-25 at 11 46 17@2x
@m-allanson m-allanson mentioned this issue Feb 25, 2024
Merged
@jhinch jhinch mentioned this issue Mar 27, 2024
Closed
@m-allanson
Copy link
Contributor Author

Closing as the fix in #224 was merged and released in table@6.8.2. Thanks @nam-hle!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@m-allanson