Skip to content

Remove unreachable width assertions #161

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Apr 23, 2021
Merged

Conversation

nam-hle
Copy link
Collaborator

@nam-hle nam-hle commented Apr 23, 2021

Continue #158.
Also, move the the width must be an integer greater than 1 condition to the schema.

@coveralls
Copy link

coveralls commented Apr 23, 2021

Pull Request Test Coverage Report for Build 311

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 100.0%

Totals Coverage Status
Change from base Build 308: 0.0%
Covered Lines: 327
Relevant Lines: 327

💛 - Coveralls

@nam-hle nam-hle marked this pull request as ready for review April 23, 2021 02:02
@gajus gajus merged commit 07aca6a into gajus:master Apr 23, 2021
@gajus
Copy link
Owner

gajus commented Apr 23, 2021

🎉 This PR is included in version 6.4.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@gajus gajus added the released label Apr 23, 2021
nam-hle added a commit to nam-hle/table that referenced this pull request Apr 24, 2021
* Remove unreachable width assertions

* Remove unreachable width assertions

* Revert width assertion in stream config

Co-authored-by: Nam Hoang Le <nam.hoang.le@mgm-tp.com>
@nam-hle nam-hle deleted the unreach-width branch October 31, 2021 13:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants