Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not include highlights from non-matching branches #4

Open
gajus opened this issue Nov 8, 2021 · 0 comments
Open

Do not include highlights from non-matching branches #4

gajus opened this issue Nov 8, 2021 · 0 comments
Labels
bug Something isn't working

Comments

@gajus
Copy link
Owner

gajus commented Nov 8, 2021

test.skip(
  'does not include highlights from non-matching branches',
  testQuery,
  'name:foo AND NOT name:foo',
  {
    name: 'foo',
  },
  [],
);

liqe/test/liqe/highlight.ts

Lines 233 to 241 in 62bf2c0

test.skip(
'does not include highlights from non-matching branches',
testQuery,
'name:foo AND NOT name:foo',
{
name: 'foo',
},
[],
);

This test should produce empty result. However, it instead produces name:foo match.

We need to exclude highlights from the entire group if the group is rejected.

@gajus gajus added the bug Something isn't working label Nov 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant