docs(contributing): spelling and grammar fixes #879
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brettz9
requested changes
Apr 23, 2022
| @@ -57,8 +57,8 @@ See ESLint's [RuleTester](https://eslint.org/docs/developer-guide/nodejs-api#rul | |||
| for more on the allowable properties (e.g., `code`, `errors` (for invalid rules), | |||
| `options`, `settings`, etc.). | |||
|
|
|||
| Note that besides `npm test`, there is `npm run test-cov` which shows more | |||
| detailed information on coverage. Coverage should be maintained at 100%, and | |||
| Note that besides `npm test` there is `npm run test-cov`, which shows more | |||
There was a problem hiding this comment.
Suggested change
| Note that besides `npm test` there is `npm run test-cov`, which shows more | |
| Note that besides `npm test` there is `npm run test-cov` which shows more |
I don't think there is need for a comma here.
There was a problem hiding this comment.
Thrown the comma in front of "which" because it is introducing a non-defining/non-restrictive clause.
I think the following article explain this change far better than I can!:
|
Thanks for the fixes! |
|
🎉 This PR is included in version 39.2.8 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Minor cleanup to improve conciseness as well as fix a few spelling and grammar issues