fix(require-param-type): report column=1
#875
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Source ```js /** * @param {a xxx * @param {bc */ ``` Before ``` 2:0 error Missing JSDoc @param "" type jsdoc/require-param-type 3:0 error Missing JSDoc @param "" type jsdoc/require-param-type ``` After ``` 2:1 error Missing JSDoc @param "" type jsdoc/require-param-type 3:1 error Missing JSDoc @param "" type jsdoc/require-param-type ```
Also: - test: adds test for `require-param-type`
|
🎉 This PR is included in version 39.2.3 🎉 The release is available on: Your semantic-release bot 📦🚀 |
|
LGTM--thanks for the report! |
crapStone
pushed a commit
to Calciumdibromid/CaBr2
that referenced
this pull request
Apr 25, 2022
This PR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | [eslint-plugin-jsdoc](https://github.com/gajus/eslint-plugin-jsdoc) | devDependencies | patch | [`39.2.1` -> `39.2.4`](https://renovatebot.com/diffs/npm/eslint-plugin-jsdoc/39.2.1/39.2.4) | --- ### Release Notes <details> <summary>gajus/eslint-plugin-jsdoc</summary> ### [`v39.2.4`](https://github.com/gajus/eslint-plugin-jsdoc/releases/v39.2.4) [Compare Source](gajus/eslint-plugin-jsdoc@v39.2.3...v39.2.4) ##### Bug Fixes - **`require-jsdoc`:** proper reporting of end line numbers; fixes [#​843](gajus/eslint-plugin-jsdoc#843) ([4270b75](gajus/eslint-plugin-jsdoc@4270b75)) ### [`v39.2.3`](https://github.com/gajus/eslint-plugin-jsdoc/releases/v39.2.3) [Compare Source](gajus/eslint-plugin-jsdoc@v39.2.2...v39.2.3) ##### Bug Fixes - **`require-param-type`:** report column=1 ([#​875](gajus/eslint-plugin-jsdoc#875)) ([2f104f8](gajus/eslint-plugin-jsdoc@2f104f8)) ### [`v39.2.2`](https://github.com/gajus/eslint-plugin-jsdoc/releases/v39.2.2) [Compare Source](gajus/eslint-plugin-jsdoc@v39.2.1...v39.2.2) ##### Bug Fixes - **`comment`:** updates `jsdoccomment` ([0eef81c](gajus/eslint-plugin-jsdoc@0eef81c)) </details> --- ### Configuration 📅 **Schedule**: At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, click this checkbox. --- This PR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate). Co-authored-by: cabr2-bot <cabr2.help@gmail.com> Reviewed-on: https://codeberg.org/Calciumdibromid/CaBr2/pulls/1311 Reviewed-by: Epsilon_02 <epsilon_02@noreply.codeberg.org> Co-authored-by: Calciumdibromid Bot <cabr2_bot@noreply.codeberg.org> Co-committed-by: Calciumdibromid Bot <cabr2_bot@noreply.codeberg.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello, I've been dealing with an annoying bug using NeoVim + LSP + eslint. If I'm typing a function parameter from scratch, like
/** @param {nu, this plugin rightfully reports an error (require-param-type) since I haven't finished typing the type.But it reports column number = 0 which causes NeoVim's LSP client to crash, interrupting my typing.
Presumably it would be impossible to error on an empty line, so I'm hoping adding column = 1 when the upstream parser doesn't report a column number is okay as a quick fix. I'm sure there is a better way to get the real column number but I don't have time to dig any deeper right now.
Not sure if other rules are affected or not, this is the only one I ran into.
Thanks!
x.jsyarn eslint x.jsbefore commityarn eslint x.jsafter commit