Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Working with Emacs #843

Closed
trev-dev opened this issue Feb 24, 2022 · 8 comments · Fixed by #881
Closed

Working with Emacs #843

trev-dev opened this issue Feb 24, 2022 · 8 comments · Fixed by #881
Labels
bug-unconfirmed help wanted released

Comments

@trev-dev
Copy link

trev-dev commented Feb 24, 2022 •
edited by brettz9

I can get this plugin to work well with VSCode, but when I try to use it with lsp-mode in Emacs, flycheck tilts and shows a red "!".

I spent some time configuring lsp-mode to stay out of eslint, and to just enable ordinary javascript-eslint with flycheck. That got the warning hints to actually show up in JS-Mode, but now subtle nuances are list (like importing a typedefs.js).

I'm not even sure where to start with this problem. Has anyone managed to get things working with emacs lsp-mode?

Want to back this issue? Post a bounty on it! We accept bounties via Bountysource.
@spenserw
Copy link
Contributor

I am unfortunately dealing with this issue as well. I was able to narrow it down (at least in my case) to the rule jsdoc/require-jsdoc... Disabling this rule allows lsp-mode to display errors properly again, even while still extending plugin:jsdoc/recommended. Anyone have any idea what this rule may do differently?

@brettz9
Copy link
Collaborator

brettz9 commented Apr 20, 2022

Have what I think should be a fix coming your way shortly. Let me know if it works.

@gajus
Copy link
Owner

gajus commented Apr 20, 2022

🎉 This issue has been resolved in version 39.2.4 🎉

The release is available on:

Your semantic-release bot 📦🚀

@gajus gajus added the released label Apr 20, 2022
@spenserw
Copy link
Contributor

spenserw commented Apr 20, 2022 •
edited

@brettz9 Wow, quick turnaround! Unfortunately this did not fix the issue for me. Anytime jsdoc/require-jsdoc is caught by the linter, all of my errors no longer display. Disabling the rule or removing the error restores proper error display.

I confirmed this on 39.2.4 and 39.2.5.

EDIT: Doing some tinkering, I added a column to the end of loc. This seems to fix it on my end. Opened #881.

@spenserw spenserw mentioned this issue Apr 20, 2022
Merged
brettz9 pushed a commit that referenced this issue Apr 20, 2022
@spenserw
fix(require-jsdoc): add column to end line (#881); fixes #843
b65fb3b
@brettz9
Copy link
Collaborator

brettz9 commented Apr 20, 2022

Ah, that makes sense. I was focused on ensuring it did cover the whole line (as a prior issue had requested that), but as long as the line is one higher, there can, and apparently, should, always be some column too. Thanks!

@gajus
Copy link
Owner

gajus commented Apr 20, 2022

🎉 This issue has been resolved in version 39.2.6 🎉

The release is available on:

Your semantic-release bot 📦🚀

@brettz9
Copy link
Collaborator

brettz9 commented Apr 20, 2022

@trev-dev : Let us know if that release fixes your issue. We can reopen if not.

@spenserw
Copy link
Contributor

@brettz9 Interesting. I don't know much about eslint internals, just decided to poke around the area you edited. Thanks for dealing with all of this so promptly!

crapStone pushed a commit to Calciumdibromid/CaBr2 that referenced this issue Apr 25, 2022
Update dependency eslint-plugin-jsdoc to v39.2.4 (#1311)
5c302c1 
This PR contains the following updates:

| Package | Type | Update | Change |
|---|---|---|---|
| [eslint-plugin-jsdoc](https://github.com/gajus/eslint-plugin-jsdoc) | devDependencies | patch | [`39.2.1` -> `39.2.4`](https://renovatebot.com/diffs/npm/eslint-plugin-jsdoc/39.2.1/39.2.4) |

---

### Release Notes

<details>
<summary>gajus/eslint-plugin-jsdoc</summary>

### [`v39.2.4`](https://github.com/gajus/eslint-plugin-jsdoc/releases/v39.2.4)

[Compare Source](gajus/eslint-plugin-jsdoc@v39.2.3...v39.2.4)

##### Bug Fixes

-   **`require-jsdoc`:** proper reporting of end line numbers; fixes [#&#8203;843](gajus/eslint-plugin-jsdoc#843) ([4270b75](gajus/eslint-plugin-jsdoc@4270b75))

### [`v39.2.3`](https://github.com/gajus/eslint-plugin-jsdoc/releases/v39.2.3)

[Compare Source](gajus/eslint-plugin-jsdoc@v39.2.2...v39.2.3)

##### Bug Fixes

-   **`require-param-type`:** report column=1 ([#&#8203;875](gajus/eslint-plugin-jsdoc#875)) ([2f104f8](gajus/eslint-plugin-jsdoc@2f104f8))

### [`v39.2.2`](https://github.com/gajus/eslint-plugin-jsdoc/releases/v39.2.2)

[Compare Source](gajus/eslint-plugin-jsdoc@v39.2.1...v39.2.2)

##### Bug Fixes

-   **`comment`:** updates `jsdoccomment` ([0eef81c](gajus/eslint-plugin-jsdoc@0eef81c))

</details>

---

### Configuration

📅 **Schedule**: At any time (no schedule defined).

🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied.

♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about this update again.

---

 - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, click this checkbox.

---

This PR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate).

Co-authored-by: cabr2-bot <cabr2.help@gmail.com>
Reviewed-on: https://codeberg.org/Calciumdibromid/CaBr2/pulls/1311
Reviewed-by: Epsilon_02 <epsilon_02@noreply.codeberg.org>
Co-authored-by: Calciumdibromid Bot <cabr2_bot@noreply.codeberg.org>
Co-committed-by: Calciumdibromid Bot <cabr2_bot@noreply.codeberg.org>
crapStone pushed a commit to Calciumdibromid/CaBr2 that referenced this issue Apr 25, 2022
Update dependency eslint-plugin-jsdoc to v39.2.8 (#1314)
85cba9b 
This PR contains the following updates:

| Package | Type | Update | Change |
|---|---|---|---|
| [eslint-plugin-jsdoc](https://github.com/gajus/eslint-plugin-jsdoc) | devDependencies | patch | [`39.2.4` -> `39.2.8`](https://renovatebot.com/diffs/npm/eslint-plugin-jsdoc/39.2.4/39.2.8) |

---

### Release Notes

<details>
<summary>gajus/eslint-plugin-jsdoc</summary>

### [`v39.2.8`](https://github.com/gajus/eslint-plugin-jsdoc/releases/v39.2.8)

[Compare Source](gajus/eslint-plugin-jsdoc@v39.2.7...v39.2.8)

##### Bug Fixes

-   update jsdoccomment ([56966d0](gajus/eslint-plugin-jsdoc@56966d0))

### [`v39.2.7`](https://github.com/gajus/eslint-plugin-jsdoc/releases/v39.2.7)

[Compare Source](gajus/eslint-plugin-jsdoc@v39.2.6...v39.2.7)

##### Bug Fixes

-   **`require-jsdoc`:** report missing blocks to next line of function with explicit column, but only as far as needed (not as far as first line's column) ([e53b441](gajus/eslint-plugin-jsdoc@e53b441))

### [`v39.2.6`](https://github.com/gajus/eslint-plugin-jsdoc/releases/v39.2.6)

[Compare Source](gajus/eslint-plugin-jsdoc@v39.2.5...v39.2.6)

##### Bug Fixes

-   **require-jsdoc:** add column to end line ([#&#8203;881](gajus/eslint-plugin-jsdoc#881)); fixes [#&#8203;843](gajus/eslint-plugin-jsdoc#843) ([b65fb3b](gajus/eslint-plugin-jsdoc@b65fb3b))

### [`v39.2.5`](https://github.com/gajus/eslint-plugin-jsdoc/releases/v39.2.5)

[Compare Source](gajus/eslint-plugin-jsdoc@v39.2.4...v39.2.5)

##### Bug Fixes

-   update `jsdoccomment` and devDep. ([fb0c83f](gajus/eslint-plugin-jsdoc@fb0c83f))

</details>

---

### Configuration

📅 **Schedule**: At any time (no schedule defined).

🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied.

♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about this update again.

---

 - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, click this checkbox.

---

This PR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate).

Co-authored-by: cabr2-bot <cabr2.help@gmail.com>
Reviewed-on: https://codeberg.org/Calciumdibromid/CaBr2/pulls/1314
Reviewed-by: Epsilon_02 <epsilon_02@noreply.codeberg.org>
Co-authored-by: Calciumdibromid Bot <cabr2_bot@noreply.codeberg.org>
Co-committed-by: Calciumdibromid Bot <cabr2_bot@noreply.codeberg.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug-unconfirmed help wanted released
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(require-jsdoc): add column to end line spenserw/eslint-plugin-jsdoc
4 participants
@brettz9 @gajus @spenserw @trev-dev