Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Classnames have trailing whitespace when spread is used #262

Open
andris-silis opened this issue Jun 30, 2019 · 3 comments
Open

Classnames have trailing whitespace when spread is used #262

andris-silis opened this issue Jun 30, 2019 · 3 comments

Comments

@andris-silis
Copy link
Contributor

Example:
JSX:

<div styleName="classA classB" {...someProps} />

Output:

<div className="classA classB " />

No trailing whitespace is added when spread is not used.

Seems like a small issue, but it breaks snapshots or className checks in tests when upgrading.

@gajus
Copy link
Owner

gajus commented Jun 30, 2019

Sees like a good first PR.

@giorgosavgeris
Copy link

Any update on this?

@Lchemist
Copy link

Sees like a good first PR.

Hi Gajus, is there any update on this issue?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants