Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: potential problem with default options #235

Merged
merged 1 commit into from Feb 24, 2019

Conversation

AlbertLucianto
Copy link
Contributor

@AlbertLucianto AlbertLucianto commented Feb 23, 2019

There can be a potential bug with the options. For example if autoResolveMultipleImports is false and assuming the default is true,

stats.opts.autoResolveMultipleImports || optionsDefaults.autoResolveMultipleImports

the result should not be true.

@gajus gajus merged commit 0e39c78 into gajus:master Feb 24, 2019
@gajus
Copy link
Owner

gajus commented Feb 24, 2019

🎉 This PR is included in version 5.2.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

@gajus gajus added the released label Feb 24, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants