Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

4.12.16 React Type Declarations are overriding project configuration #1391

Closed
r0skar opened this issue Nov 8, 2019 · 2 comments · May be fixed by novalina26/anchor#1
Closed

4.12.16 React Type Declarations are overriding project configuration #1391

r0skar opened this issue Nov 8, 2019 · 2 comments · May be fixed by novalina26/anchor#1

Comments

@r0skar
Copy link

r0skar commented Nov 8, 2019

Description

While starting up my project today, I noticed that my own JSX types dont work anymore (I am not using React). I am using the babel plugin jsx-dom-expressions, which comes with their own JSX typings. However these are now in conflict with @types/react and tsc throws hundredths of errors. Unfortunately, TS is not yet able to exclude a specific dts file. This is related to the changes in #1359. Any chance this change could be reverted so that we can again use react-hot-loader in a project where the JSX is not compiled by React?

Environment

React Hot Loader version: 4.12.16

Run these commands in the project folder and fill in their results:

  1. node -v: v12.13.0
  2. npm -v: 6.12.1
  3. yarn -v: 1.19.1
@theKashey
Copy link
Collaborator

Look like #1359 was not a great idea

@theKashey
Copy link
Collaborator

4.12.17 released

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants