Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Respect socket timeout #431

Merged
merged 3 commits into from May 24, 2021
Merged

Respect socket timeout #431

merged 3 commits into from May 24, 2021

Conversation

gabrielfalcao
Copy link
Owner

@gabrielfalcao gabrielfalcao commented May 24, 2021

This PR closes #430.

@mariojonke thanks for the test case, I'll mention it in a new section of "guides" in the docs.

Your test-case caught a mistake I made in fixing #428 馃槄 :

t.join(None)

@gabrielfalcao gabrielfalcao self-assigned this May 24, 2021
@codecov
Copy link

codecov bot commented May 24, 2021

Codecov Report

Merging #431 (da624d4) into master (19880d8) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #431   +/-   ##
=======================================
  Coverage   81.94%   81.94%           
=======================================
  Files           7        7           
  Lines        1113     1113           
  Branches      159      159           
=======================================
  Hits          912      912           
  Misses        147      147           
  Partials       54       54           
Impacted Files Coverage 螖
httpretty/core.py 80.51% <100.00%> (酶)

Continue to review full report at Codecov.

Legend - Click here to learn more
螖 = absolute <relative> (impact), 酶 = not affected, ? = missing data
Powered by Codecov. Last update 19880d8...da624d4. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

HTTPretty does not respect timeouts anymore
1 participant