Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Default image output from buildx v0.10 cannot run on Google Cloud Run or AWS Lambda/ECS #407

Closed
darpham opened this issue Jan 29, 2023 · 1 comment · Fixed by #410
Closed

Comments

@darpham
Copy link
Contributor

darpham commented Jan 29, 2023

Background

docker/buildx#1533
docker/build-push-action#781

As of Buildx 0.10, images are built with provenance -- this behavior is opt-out, and can be disabled with --provenance=false if using the buildx build cl

Images built with these default attestations that use the attestation storage from buildkit cannot be run on Google Cloud Run or AWS Lambda. While both Cloud Run and Lambda support the OCI format, they do not support multi-platform images.

Changes?

Add provenance arg for BuildxCLI

def build(
        self,
        ...
        provenance: ...,
    )...
...
        full_cmd.add_args_list("--provenance", format_dict_for_cli(provenance))
@darpham darpham changed the title Default image output from buildx v0.10 cannot run on Google Cloud Run or AWS Lambda Default image output from buildx v0.10 cannot run on Google Cloud Run or AWS Lambda/ECS Jan 29, 2023
@gabrieldemarmiesse
Copy link
Owner

Hi! Thank you for the report! It seems like it is quite a big issue. As always, I'm open to pull requests to support new options added to Docker :) If nobody does the pull request, I'll do it when I have the time. If you decide to make the pull request, please make some minimal unit tests

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants