Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make difference between package -release and release on mobile. #3346

Merged
merged 1 commit into from Oct 23, 2022

Conversation

Bluebugs
Copy link
Contributor

Description:

It is expected that package -release generate a binary stripped from as much information as possible (On mobile it means stripping debug information, but not stripping of symbol). While it is expected that release generate a signed package for consumption by stores.

Checklist:

  • Tests included.
  • Lint and formatter run with no errors.
  • Tests all pass.

It is expected that package -release generate a binary stripped from as
much information as possible (On mobile it means stripping debug
information, but not stripping of symbol). While it is expected that
release generate a signed package for consumption by stores.
@coveralls
Copy link

Coverage Status

Coverage decreased (-0.02%) to 61.3% when pulling 4e9e183 on bugs/mobile-package-release into 63ddee5 on develop.

@andydotxyz
Copy link
Member

Looks good to me, can Jacob or one other confirm our discussion from #fyne-contributors makes sense and is solved by this?

Copy link
Member

@Jacalz Jacalz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The code makes sense but I am not entirely sure what the discussion in #fyne-contributors was about. Left a small comment inline.

cmd/fyne/internal/mobile/build.go Show resolved Hide resolved
@Bluebugs Bluebugs merged commit ee54420 into develop Oct 23, 2022
@Bluebugs Bluebugs deleted the bugs/mobile-package-release branch October 23, 2022 16:43
Bluebugs added a commit to Bluebugs/fyne that referenced this pull request Nov 1, 2022
Make difference between package -release and release on mobile.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants