Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Features/detect available min api #3219

Merged
merged 1 commit into from Aug 30, 2022

Conversation

Bluebugs
Copy link
Contributor

Description:

With latest NDK r25.b, I do not have the same minimum available API version for the compiler. To make it a bit more resilient to this kind of change, the code in the PR will automatically probe the filesystem to find the lowest available version.

This are all internal change and does not impact any ABI/API outside of fyne command line.

Checklist:

  • Tests included.
  • Lint and formatter run with no errors.
  • Tests all pass.

Where applicable:

  • Public APIs match existing style and have Since: line.
  • Any breaking changes have a deprecation path or have been discussed.
  • Updated the vendor folder (using go mod vendor).
  • Check for binary size increases when importing new modules.

@Bluebugs Bluebugs changed the base branch from master to develop August 23, 2022 17:33
@coveralls
Copy link

Coverage Status

Coverage decreased (-0.1%) to 61.413% when pulling 6b119e0 on Bluebugs:features/detect-available-minAPI into f4be32d on fyne-io:develop.

Copy link
Member

@andydotxyz andydotxyz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pretty sure this will resolve #3066

Copy link
Member

@toaster toaster left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Bluebugs Bluebugs merged commit d8eb66c into fyne-io:develop Aug 30, 2022
@Bluebugs Bluebugs deleted the features/detect-available-minAPI branch August 30, 2022 20:13
Bluebugs added a commit to Bluebugs/fyne that referenced this pull request Nov 1, 2022
…le-minAPI

Features/detect available min api
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants