Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix incorrect size and position for radio focus indicator #3137

Merged
merged 3 commits into from Jul 13, 2022

Conversation

Jacalz
Copy link
Member

@Jacalz Jacalz commented Jul 13, 2022

Description:

This fixes an issue where the incorrect amount of padding was added to the focus indicator in radioItem.

Before:

image

After:

image

Checklist:

  • Tests included.
  • Lint and formatter run with no errors.
  • Tests all pass.

@Jacalz Jacalz changed the title Fix/radio focus indicator Fix incorrect size and position for radio focus indicator Jul 13, 2022
@coveralls
Copy link

Coverage Status

Coverage increased (+0.006%) to 61.451% when pulling d0f567e on Jacalz:fix/radio-focus-indicator into 7a3ae4d on fyne-io:release/v2.2.x.

Copy link
Contributor

@Bluebugs Bluebugs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It would be nice to split commit next time with cosmetic change (like *0.5 -> /2 or reordering code) that are orthogonal to the fix to a different commit to make review a bit easier.

@Jacalz
Copy link
Member Author

Jacalz commented Jul 13, 2022

It would be nice to split commit next time with cosmetic change (like *0.5 -> /2 or reordering code) that are orthogonal to the fix to a different commit to make review a bit easier.

Sure thing. Sorry about that.

@Jacalz Jacalz merged commit bbe9e72 into fyne-io:release/v2.2.x Jul 13, 2022
@Jacalz Jacalz deleted the fix/radio-focus-indicator branch July 13, 2022 18:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants