Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't forget about icons set before systray menu #3103

Merged
merged 2 commits into from Jun 27, 2022
Merged

Don't forget about icons set before systray menu #3103

merged 2 commits into from Jun 27, 2022

Conversation

andydotxyz
Copy link
Member

If it is set before the menu the init code overwrote it.

Checklist:

  • Tests included. <- this relates to the order of events in systray package
  • Lint and formatter run with no errors.
  • Tests all pass.

@coveralls
Copy link

coveralls commented Jun 27, 2022 •
edited

Coverage Status

Coverage decreased (-0.006%) to 61.376% when pulling 9689be8 on andydotxyz:fix/preicon into 282ae68 on fyne-io:release/v2.2.x.

toaster
toaster requested changes Jun 27, 2022
View reviewed changes
Copy link
Member

@toaster toaster left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please use a better name for iconSet.

internal/driver/glfw/driver_desktop.go Outdated Show resolved Hide resolved
@andydotxyz andydotxyz requested a review from toaster June 27, 2022 20:35
@andydotxyz andydotxyz merged commit 87f879a into fyne-io:release/v2.2.x Jun 27, 2022
@andydotxyz andydotxyz deleted the fix/preicon branch June 27, 2022 21:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@d1ss0nanz d1ss0nanz d1ss0nanz left review comments

@toaster toaster Awaiting requested review from toaster

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@andydotxyz @coveralls @toaster @d1ss0nanz