dialog: show file extension in list view #3033
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It seemed like a sensible improvement to show the file extension when using the list view. This is due to the icons being a lot smaller.
|
The option in VSCode to only run a specific test is very useful but does apparently not help when you break other tests 🙈 |
andydotxyz
requested changes
Jun 3, 2022
| } else { | ||
| item.name = fileName(location) | ||
| if f.view == gridView { | ||
| ext := filepath.Ext(item.name[1:]) |
There was a problem hiding this comment.
I think this might crash for a file named "H"?
There was a problem hiding this comment.
It seems like it actually doesn't. We were doing the same thing in the code that I removed.
andydotxyz
approved these changes
Jun 3, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Due to icons being a lot smaller for the list view, we should show the file extension to make it more clear to the user what file they are seeing. This PR makes that change and manages to clean up and optimize the code a bit in the process.
Fixes Jacalz/rymdport#39 but should be superseded by #3032 for a future release.
Checklist: